Added telldus-core install script #56
Conversation
|
@EliasGabrielsson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ThomDietrich, @BClark09 and @jupe76 to be potential reviewers. |
|
Note that this needs a minor rewrite if pull request #55 get merged. The user accounts is hard-coded in the script. |
This add installation script for the service telldus-core and matching samba share. Telldus-core enables usage of tellstick usb devices to communicate with openhab. Signed-off-by: Elias Gabrielsson <elias@benefactory.se>
There was a problem hiding this comment.
Thanks for the addition. I've added one comment. Besides that I'm not happy with the samba symlinks change. Do you need the samba share? Is there a better solution?
What's the reason for including https://bitbucket.org/davka003/pytelldus.git and of "alias tdtool"? Both are not mentioned in the introtext and davka003 doesn't look like the "official repository"...
| if [ $? -ne 0 ]; then echo "FAILED"; exit 1; fi | ||
| cond_redirect sed -i '/############ Misc ############/a allow insecure wide links = yes' /etc/samba/smb.conf | ||
| cond_redirect chown -R openhab:pi /opt /var/lib/tellstick | ||
| cond_redirect chmod -R g+w /opt |
There was a problem hiding this comment.
You don't need to handle /opt here, that's done in another place.
|
Put review of this on hold until the password PR is solved. a) I have tested this script for a while now and have found an edge case with the symlink method. b) Telldus the creator of tellstick have for some unspoken reason not included a But I fully agree that this shall be mention in the introtext. |
ThomDietrich
force-pushed
the
master
branch
2 times, most recently
from
f5d1f2d
to
a10d130
Compare
ThomDietrich
force-pushed
the
master
branch
2 times, most recently
from
9511dfd
to
edebbcd
Compare
ThomDietrich
force-pushed
the
master
branch
12 times, most recently
from
f8fdf71
to
cd1737a
Compare
This add installation script for the service telldus-core and matching samba share.
Telldus-core enables usage of tellstick usb devices to communicate with openhab.
Signed-off-by: Elias Gabrielsson elias@benefactory.se