Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PINEA64, Jessie, Xenial #971

Merged
merged 4 commits into from
Jun 17, 2020
Merged

Conversation

mstormi
Copy link
Contributor

@mstormi mstormi commented Jun 16, 2020

Removed special handling for any of these.
openhabian-config will determine if running on deprecated HW or OS and eventually issue a warning on startup.

Fixes #622
Fixes #623

Signed-off-by: Markus Storm markus.storm@gmx.net

@mstormi
Copy link
Contributor Author

mstormi commented Jun 16, 2020

I left the PINE code in so we do not intentionally break running on there
@holgerfriedrich can you remove PINE from build.bash ? You've got a better overview of how that works there.

I removed all code for now unsupported OS releases, i.e. specific code for trusty, xenial and jessie as users always have the choice to dist-upgrade.

@holgerfriedrich
Copy link
Member

@mstormi could do, but too many conflicting PRs out there right now. Let's wait until this settles.
And then remember to drop build-image/rc.local as well.

@holgerfriedrich
Copy link
Member

regarding the announcement: Deprecating support is somehow misleading, we deprecated support before. Now we are actually removing the code/exceptions from our codebase, so openHABian is likely to break.....

@ecdye
Copy link
Contributor

ecdye commented Jun 17, 2020

Don't forget that when we get rid of rc.local we need to change the way that build.bash local-test works.

Copy link
Contributor

@ecdye ecdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -68,12 +68,6 @@ Check the \"openHAB Release Notes\" and the official announcements to learn abou
openhabVersion="$(apt-cache madison openhab2 | head -n 1 | cut -d'|' -f2 | xargs)"

local APT_INST_OPTS="-y --allow-downgrades"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would appear that this variable is no longer necessary. please remove it and put the options in the command itself

@@ -177,7 +177,7 @@ is_raspbian() {
[[ "$(cat /etc/*release*)" =~ "Raspbian" ]]
return $?
}
# Debian/Raspbian, to be deprecated, LTS ends 2020-06-30
# Debian/Raspbian, deprecated, LTS ended 2020-06-30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, my computer claims that the date is only 2020-06-16 which means that this claim is currently false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehehe I was wondering if anyone would notice :)
But I didn't want to do another PR in 2 weeks

@mstormi
Copy link
Contributor Author

mstormi commented Jun 17, 2020

too many conflicting PRs out there right now. Let's wait until this settles.

Ok will merge #938 then rebase this here. But it should be in with [before] the image builder PR

And then remember to drop build-image/rc.local as well.

Dunno what you refer to. Please take care of that in a PR of yours.

@mstormi
Copy link
Contributor Author

mstormi commented Jun 17, 2020

regarding the announcement: Deprecating support is somehow misleading

agree, I changed it to "removed support"

Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Another PR for build.bash and related is required, but after #931 is merged as I do not want to mix up topics in one PR.

NEWS.md Outdated Show resolved Hide resolved
Signed-off-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Markus Storm <markus.storm@gmx.net>
@mstormi mstormi merged commit 4d876c5 into openhab:master Jun 17, 2020
@mstormi mstormi deleted the deprecatejessie branch July 20, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants