-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PINEA64, Jessie, Xenial #971
Conversation
I left the PINE code in so we do not intentionally break running on there I removed all code for now unsupported OS releases, i.e. specific code for trusty, xenial and jessie as users always have the choice to dist-upgrade. |
@mstormi could do, but too many conflicting PRs out there right now. Let's wait until this settles. |
regarding the announcement: Deprecating support is somehow misleading, we deprecated support before. Now we are actually removing the code/exceptions from our codebase, so openHABian is likely to break..... |
Don't forget that when we get rid of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
functions/openhab.bash
Outdated
@@ -68,12 +68,6 @@ Check the \"openHAB Release Notes\" and the official announcements to learn abou | |||
openhabVersion="$(apt-cache madison openhab2 | head -n 1 | cut -d'|' -f2 | xargs)" | |||
|
|||
local APT_INST_OPTS="-y --allow-downgrades" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would appear that this variable is no longer necessary. please remove it and put the options in the command itself
functions/helpers.bash
Outdated
@@ -177,7 +177,7 @@ is_raspbian() { | |||
[[ "$(cat /etc/*release*)" =~ "Raspbian" ]] | |||
return $? | |||
} | |||
# Debian/Raspbian, to be deprecated, LTS ends 2020-06-30 | |||
# Debian/Raspbian, deprecated, LTS ended 2020-06-30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an aside, my computer claims that the date is only 2020-06-16 which means that this claim is currently false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehehe I was wondering if anyone would notice :)
But I didn't want to do another PR in 2 weeks
Ok will merge #938 then rebase this here. But it should be in with [before] the image builder PR
Dunno what you refer to. Please take care of that in a PR of yours. |
agree, I changed it to "removed support" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Another PR for build.bash and related is required, but after #931 is merged as I do not want to mix up topics in one PR.
Signed-off-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Markus Storm <markus.storm@gmx.net>
Signed-off-by: Markus Storm <markus.storm@gmx.net>
Removed special handling for any of these.
openhabian-config will determine if running on deprecated HW or OS and eventually issue a warning on startup.
Fixes #622
Fixes #623
Signed-off-by: Markus Storm markus.storm@gmx.net