Add check to generate a warning if the exception is not added as a last parameter #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinvw, please take a look when you have time for that. |
ghost
force-pushed
the
exception-last-parameter-check
branch
3 times, most recently
from
55a95ff
to
d714840
Compare
|
@tanyatanyatanya, please update the PR with the utility methods added in #287 |
|
@tanyatanyatanya Can you please adapt the PR according to the changes in #287 ? |
ghost
force-pushed
the
exception-last-parameter-check
branch
from
d714840
to
c347363
Compare
|
@dstivanov Done. |
|
There is a pmd check that kind of checks for this too: UseCorrectExceptionLogging. Was that considered or doesn't cover the use case implemented in this check? |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new check to generate a warning if the exception is not added as a last parameter to the logging for caught and logged unchecked exceptions.
Fixed #221