Base styling for: affixed ToC, example blocks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nmu
commented
Dec 15, 2013
nmu
commented
|
Looks good! I still have concerns about the TOC (see my email). |
shaunagm
added a commit
that referenced
this pull request
Dec 15, 2013
Base styling for: affixed ToC, example blocks
|
Upon review, it looks like the sub-section headings are slightly larger than the section headings. I think this is because h1-h3 (title, subtitle, and section headings) are defined in custom.css, while sub-headings (h4 and higher) are not. In my browser (Chrome 29 on Ubuntu) at least, the default for h4 is larger than what's specified for h3. Viewing locally, I don't like how small you have to make h4, to be smaller than h3. So I've bumped h3 up in size. Let me know what you think, @nmu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.