Use custom bug parser specified, not hardcoded RoundupBugParser #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @catherinedevlin and @ehashman , It occurs to me that we should probably add a test to cover this behavior. I realize it's taken days of process and delay to merge this one-line fix.... Is that something either of you are able to do? If not, I can try to do it this weekend, so that I can merge this while feeling great about it. |
|
I can add/modify the test cases appropriately, possibly tonight. Catherine, let me know if you'd like me to do that or if you'd prefer to. |
|
Someone else is going to look into adding the aforementioned test case in another PR. Merging. |
ehashman
added a commit
that referenced
this pull request
May 11, 2014
Use custom bug parser specified, not hardcoded RoundupBugParser
This was referenced Aug 7, 2014
This was referenced Sep 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://openhatch.org/bugs/issue962 (roundup.py was ignoring specified custom bug parser)