Merge pull request #183 from urbackmk/747

changing search autocomplete from html input title attribute to placehol...
openhatch · Jan 5, 2014 · 11d49b9 · 11d49b9
2 parents 3c32634 + cbadd33
commit 11d49b9
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 108 deletions.
diff --git a/mysite/base/assets.py b/mysite/base/assets.py
@@ -39,7 +39,6 @@
 register('openhatch_js',
          # jQuery
          Bundle('js/jquery.json.js',
-                'js/jquery.hint.js',
                 'js/jquery.form.js',
                 'js/jquery.jgrowl.js',
                 'js/jquery.tipsy.js',

diff --git a/mysite/base/templates/mission.html b/mysite/base/templates/mission.html
@@ -48,7 +48,7 @@ <h3> Steps </h3>
                             <li>Look up the online bug tracker of your
                                 favorite project, and enter the URL of
                                 a good-looking bug here:
-                                <input rel='hint' name='bug_url' type='text' title='Paste a bug URL here' style='width: 300px; float: none; margin-top: 3px; display: block;'/>
+                                <input rel='hint' name='bug_url' type='text' placeholder='Paste a bug URL here' style='width: 300px; float: none; margin-top: 3px; display: block;'/>
                             </li>
                         </ul>
                     </li>

diff --git a/mysite/profile/templates/profile/portfolio/portfolio_entry_element.html b/mysite/profile/templates/profile/portfolio/portfolio_entry_element.html
@@ -59,7 +59,7 @@
                 {% endif %}
                 
                 {% if adding_mode %}
-                    <input class='project_name' type='text' title="Type a project name" value='' />
+                    <input class='project_name' type='text' placeholder="Type a project name" value='' />
                 {% else %}
 
                 <span class='project_name'>

diff --git a/mysite/project/templates/project/project.html b/mysite/project/templates/project/project.html
@@ -401,12 +401,10 @@ <h3>Registered contributors ({% firstof project.get_contributor_count "none list
                     $form.find('input:text, textarea').unbind('blur');
                 });
 
-            $('input:text, textarea').hint();
             // Bind a function to the 'x' on input forms.  this function collapses the form
             $('.collapse_answer_form').click(function(){
                 $form = $(this).parent().parent();
                 $form.removeClass('active');
-                $form.find('input:text, textarea').hint();
                 if($form.hasClass('is_edit_form')){
                     $form.hide();
                     answer_id = $(this).attr('id').split('_')[3];

diff --git a/mysite/search/templates/search/search.html b/mysite/search/templates/search/search.html
@@ -197,7 +197,7 @@ <h4 id='how_many_projects'>
         <div class='module-body'>
             <form name='search_opps' method='GET' id='search_fulltext' action='{% url mysite.search.views.search_index %}'> 
                 <input type='text' name='q' id='q' rel='hint'
-                title='Textual search'
+                placeholder='Textual search'
                 value='{{ query.terms_string }}' />
 
                 {% for facet, value in query.active_facet_options.items %}

diff --git a/mysite/static/how-to-build-openhatch.html b/mysite/static/how-to-build-openhatch.html
@@ -259,7 +259,6 @@ <h3>Download the source</h3>
         <script type='text/javascript' src="/static/js/jquery-ui-1.7.2.custom.min.js?x"></script>
 
         <script type='text/javascript' src="/static/js/jquery.json.js?x"></script>
-        <script type='text/javascript' src="/static/js/jquery.hint.js?x"></script>
         <script type='text/javascript' src="/static/js/jquery.form.js?x"></script>
         <script type='text/javascript' src="/static/js/jquery.jgrowl.js?x"></script>
         <script type='text/javascript' src="/static/piwik.js?x"></script>
@@ -290,13 +289,10 @@ <h3>Download the source</h3>
                     $form.addClass('active');
                     $form.find('input:text, textarea').unbind('blur');
                 });
-
-            $('input:text, textarea').hint();
             // Bind a function to the 'x' on input forms.  this function collapses the form
             $('.collapse_answer_form').click(function(){
                 $form = $(this).parent().parent();
                 $form.removeClass('active');
-                $form.find('input:text, textarea').hint();
                 if($form.hasClass('is_edit_form')){
                     $form.hide();
                     answer_id = $(this).attr('id').split('_')[3];

diff --git a/mysite/static/js/base.js b/mysite/static/js/base.js
@@ -88,7 +88,6 @@ $.fn.toggleDisplay = function() {
 }
 
 $(function () {
-    $("input[rel='hint']").hint();
     $("a[rel='facebox']").facebox();
 });
 

diff --git a/mysite/static/js/importer.js b/mysite/static/js/importer.js
@@ -908,7 +908,6 @@ Importer.Inputs.init = function () {
             "Type a repository username here");
     Importer.Inputs.getInputs().eq(1).attr('title',
             "Type an email address here");
-    Importer.Inputs.getInputs().hint();
 };
 Importer.Inputs.makeNew = function () {
 
@@ -1025,7 +1024,6 @@ PortfolioEntry.Add.clickHandler = function (project_name) {
     }
 
     PortfolioEntry.bindEventHandlers();
-    $add_a_pf_entry.find('input[title]').hint();
 
     return false;
 };

diff --git a/mysite/static/js/jquery.hint.js b/mysite/static/js/jquery.hint.js
diff --git a/mysite/static/js/search/defaultText.js b/mysite/static/js/search/defaultText.js