Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Settings page has a horizontal scroll bar #1613

Open
gkhaburzaniya opened this issue Apr 15, 2015 · 4 comments
Open

Edit Settings page has a horizontal scroll bar #1613

gkhaburzaniya opened this issue Apr 15, 2015 · 4 comments
Labels
css pri:bug stat:unread

Comments

@gkhaburzaniya
Copy link

It probably shouldn't

image
@sunilkumarc
Copy link
Contributor

I just checked the Box model of the body element of the account/settings page. This is what it looks like
account_settings
The padding and margin-bottom are not 0 for this element on this page.

Whereas in other pages it looks like this
other_pages

I think this is the issue.

@ehashman
Copy link
Member

+1 @sunilkumarc! Yes, I've also noticed that the layout in settings is off for some reason (as you can see, there's ~10px of padding on the top/left). That may be contributing.

@ehashman ehashman added the css label Apr 16, 2015
@sunilkumarc
Copy link
Contributor

In the account/settings page, body element looks like this
<body id='body' class='one_column auth settings'>

Styling for these class properties have been done in this file
https://github.com/openhatch/oh-mainline/blob/master/mysite/static/css/account/settings.css#L2&#L3

I'm not sure why margin and padding-bottom are required for body.settings.

@ehashman
Copy link
Member

That's probably a bug; if you want to play around with removing that class (or just properties of that class) and submit a PR, I'd be happy to take a look.

@palbakulich palbakulich mentioned this issue Jun 15, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css pri:bug stat:unread
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sunilkumarc @gkhaburzaniya @ehashman