Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 873 The logged-in user's user page now contain special hints #127

Closed
wants to merge 1 commit into from

Conversation

ArcTanSusan
Copy link
Contributor

https://openhatch.org/bugs/issue873 I've tested this patch locally; the UI looks very different now. Feel free to code review. Thanks. cc/ @paulproteus @aldeka

@paulproteus
Copy link
Contributor

Hi @onceuponatimeforever ! Sorry about the delay in my response! It's really exciting that you're taking a look at our templates.

One thing that I was thinking was that it'd be easier if the logged-in users template were the same as the non-logged-in-users template (that is, the file were the same, but there were "if" logic that added or removed parts). This way, it would be easier to think about that as a single page.

Further review soon. Sorry to be so distant. Perhaps @aldeka can provide more in the near future; I'll try to be back within a day or so.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c3d3712 on onceuponatimeforever:873 into 3c32634 on openhatch:master.

…l hints for them.

Thanks britta for the mockup.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c3d3712 on onceuponatimeforever:873 into 3c32634 on openhatch:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.23%) when pulling c3d3712 on onceuponatimeforever:873 into 3c32634 on openhatch:master.

@ArcTanSusan
Copy link
Contributor Author

Here's the new UI. I integrated the new "Mission" and an "Acitivity Feed" into the user profile page. It's based on Britta's mockup, but I've kept the "Projects" html module. See screenshot below:

873_new_profile_page

@brittag
Copy link
Contributor

brittag commented Feb 16, 2014

Interesting, I had consolidated the "Projects" module with the list titled "I have helped", since my understanding is that these are the same lists. But this version doesn't have anything under "I have helped". Are they different lists?

@willingc
Copy link
Member

@onceuponatimeforever Great changes are happening with your Django work :)

I'm doing a little PR housekeeping this afternoon. I reran the Travis CI build on this pull request rebased on current master, and Travis is still red.

Should this pull request be closed as a stale pull request? Or are these user interface changes still relevant and we can keep it open? Either way is cool; just let me know. Thanks!

@brittag
Copy link
Contributor

brittag commented Jul 8, 2014

I'd support keeping this open - the current website interface works, but it'd still be nice to add back "hints" for logged-in users (in some form).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants