remove populate_icon_from_ohloh #1530
Conversation
| model_project.populate_icon_from_ohloh() | ||
| # We know this is unsafe. | ||
| # If this fails, it might be because | ||
| # populate_icon_from_ohloh doesn't exist anymore. |
There was a problem hiding this comment.
Generally, you shouldn't modify anything in a migrations directory, as all the contents there are auto-generated by South for Django apps that are older than Django 1.7. Instead, use South to do a migration on the command line, which will add a migration file (to be git committed): http://south.readthedocs.org/en/latest/tutorial/part1.html
There was a problem hiding this comment.
@onceuponatimeforever , on #1524, you can see why I changed the migrations in django, those are custom migrations and needed to be changed after I had removed populate_icon_from_ohloh() else would have caused AttributeError .
On an other note I don't know if I should add a migration.. It seemed to pass the tests.
There was a problem hiding this comment.
Can you run a migration to see if any new migration files get generated?
|
LGTM 🍎 Looks like there are no additional migrations needed. |
remove populate_icon_from_ohloh
|
Thanks :D @onceuponatimeforever |
fix for #1524
Do recommend changes if required.