Fixing #919 Sometimes /account/settings/location/ crashes #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added local_settings.py existing iceland test fails. I am puzzled. Added new test, I still cannot repro the bug. Help..?
|
Hi @onceuponatimeforever, Per some more recent pull requests, maybe the best thing is to simply remove our dependency on GeoLiteCity. For that reason, I'm closing this pull request. You can see the transition in the list of OpenHatch pull requests to oh-mainline. Look for things related the HTML5 geolocation API. You might be interested to see that we just added some documentation to http://openhatch.readthedocs.org/en/latest/ about the local_settings.py file. Huge thanks to @cpallares for writing that text. |
This was referenced Aug 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added local_settings.py
The existing iceland test fails. I am puzzled.
Added new test, I still cannot repro the bug. Help..?