Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the "Using tar" low hints #240

Merged
merged 1 commit into from Apr 17, 2014
Merged

Fixed the "Using tar" low hints #240

merged 1 commit into from Apr 17, 2014

Conversation

eeshangarg
Copy link
Member

Fixed: Issue 958 - In the "Using tar" mission, the first line of every low hint is way off to the right https://openhatch.org/bugs/issue958

paulproteus added a commit that referenced this pull request Apr 17, 2014
@paulproteus paulproteus merged commit 2e86225 into openhatch:master Apr 17, 2014
@eeshangarg
Copy link
Member Author

Hi! @paulproteus

I would be happy to work on all of the tasks that you mentioned, but I have to go back to Toronto on 17th April, Thursday and I will only be getting a chance to work on these once I am in Toronto.

From now on, I'll try to analyze the problem that I'm working on and see if it can be or if it is necessary to break it down into separate issues based on the type of problems.

I'll be adding the comment in base.css about the clear: both;, but one question, should I file a separate issue about the comment or should I just make a commit?

And, yes, I think we should add some explanations to the Front-end style guide about the clear: both; issue and about how to phrase things well in the missions. I think that it would act as a good reminder in the future when we have to tackle problems similar to these. So, I will write some guidelines in the Front-end style guide right away.

Hope you had a safe and enjoyable journey!

Thanks
Eeshan Garg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants