Updated the docs for writing new training missions #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mission by adding a new item after the other missions:: | ||
| site by telling OpenHatch how to route the URLs. Django projects define | ||
| URL routing in a file cunningly named ``urls.py``. You can find this | ||
| in the ``mysite`` directory. The first step to making your mission accessible |
There was a problem hiding this comment.
You said "final step" at the beginning of the paragraph but now you're saying "first step". This is a bit confusing. Also, you are implicitly directing the user to open urls.py here but then explicitly direct them to in line 193.
Maybe reword to "You can begin by opening urls.py. You'll need to tell it where the file views.py for your new mission..."
|
Thanks, @eeshangarg! I'll merge this once you get a chance to review my feedback. |
|
Thanks a lot, @ehashman! I made the changes as per your feedback. I learned a lot from your advice and I'll be careful next time and try to avoid these mistakes in the future. :) Regards, |
|
Looks good, merging. |
ehashman
added a commit
that referenced
this pull request
Jul 21, 2014
…ting-training-missions Updated the docs for writing new training missions
This was referenced Aug 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Issue 1019 Docs for 'Writing Training Missions' need to be updated with additional information about how to make the mission accessible