Feature/staticgenerator checks request is anonymous #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def get_user_ip(request): | ||
| # return request.META['REMOTE_ADDR'] | ||
| if request.META['REMOTE_ADDR'] == '127.0.0.1': | ||
| return "98.140.110.121" | ||
| else: | ||
| return request.META['REMOTE_ADDR'] |
aldeka
added a commit
that referenced
this pull request
Jul 13, 2012
…s-request-is-anonymous Feature/staticgenerator checks request is anonymous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, it has been possible that django-staticgenerator would save a version of pages such as /search/ that contain a basically-random user's personal information (username and "recommended searches"). Actually, given the current search.html template, probably just username.
Still, that's terrible. This modules our use of the StaticGeneratorMiddleware to avoid that problem.
(Thanks to jesstess for reporting the issue.)