Fix saving a portfolio entry (fixes issue #748) #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new project from
/+portfolio/editor/
, the code was trying to get the pk of the project by getting it fromrequest.POST['portfolio_entry__pk']
. However for new projects there is no such element, so a MultiValueDictKeyError exception was launched, and since it was not catched it resulted in a 500 error.My change uses the
.get
function of therequest.POST
object to retrieve that value, and gives it the value ofundefined
if it's not present. The next line already checksif pk == 'undefined':
, so now there is no more exception being triggered, and the new project can be created.This fixes https://openhatch.org/bugs/issue748