Feature/diffpatch mission slight cleanup #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,8 +49,13 @@ def validate_patch(cls, patchdata): | |||
| if len(the_patch.hunks) != 1: | |||
| raise IncorrectPatch, 'The patch affects more than one file.' | |||
|
|
|||
| hunk_set_for_first_file = the_patch.hunks[0] | |||
There was a problem hiding this comment.
On the second round of this expansion, you don't set a variable. why not use the_patch.hunks[0] over on line 57?
Also, since these blocks are mostly duplicated except for NEW_FILE and OLD_FILE, why not extract to a method?
There was a problem hiding this comment.
I agree that this could be a little cleaner. I'll extract a method and resubmit!
|
This version has way better comments, I believe. Review requested! |
|
👍 Love the addition of the helpful comments (and the extracted method!) |
paulproteus
added a commit
that referenced
this pull request
Nov 12, 2012
…ght-cleanup Feature/diffpatch mission slight cleanup Thanks to pselle for the review, and the comments that led to this improved patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just performs a tiny amount of cleanup on the diffpatch mission.