Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 808: "+projects" and " projects" now 302 redirects to "projects" #93

Closed
wants to merge 4 commits into from

Conversation

nZac
Copy link
Contributor

@nZac nZac commented Mar 18, 2013

Fixed 808: "+projects" and " projects" now 302 redirects to "projects"

@jwm
Copy link
Contributor

jwm commented Mar 19, 2013

There are a few parts of the test suite that expect /+projects in the URL; check out the Travis build log. At the bottom, there are ~half a dozen tests that fail:

https://travis-ci.org/openhatch/oh-mainline/jobs/5586239

Would you update those test suite bits, too? Then I can merge this, since the build will succeed again.

@paulproteus
Copy link
Contributor

Hi @nZac ,

Are you still interested in polishing this up? It'd be great to land this change, as It would address a lot of confusion that users of the site experience.

If not, then that's okay; just say so and we will see if someone else is willing to finish up the changes you've begun.

Thanks for getting this far!

@nZac
Copy link
Contributor Author

nZac commented May 13, 2013

Yea, I can take care of it. Work has been crazy so haven't looked at any OSS projects lately.

@nZac
Copy link
Contributor Author

nZac commented May 13, 2013

How does that look?

@nZac
Copy link
Contributor Author

nZac commented Jun 5, 2013

Any chance on this getting merged?

@jwm
Copy link
Contributor

jwm commented Jun 12, 2013

I've got this on my todo list for this weekend; sorry it's taken this long.

@ghost ghost assigned jesstess and jwm Jun 16, 2013
@jwm
Copy link
Contributor

jwm commented Jun 17, 2013

I've merged these commits. Thanks Nick, and nice meeting you at PyCon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants