Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering actions #10

Closed
rossjones opened this issue Oct 18, 2014 · 3 comments
Closed

Triggering actions #10

rossjones opened this issue Oct 18, 2014 · 3 comments

Comments

@rossjones
Copy link
Contributor

When we get fed up of typing when
and when we have successfully matched all the rules
then do-action with a secondary match

The :then match, should probably match on the rest of the line, so that

:then :email "" with ""

becomes another match on :email "" with ""

:then :notify "" with ""

becomes a match on :notify "" with ""

@davidmiller
Copy link
Member

+10.

I was thinking that this: would...

Then email "hello@openhealthcare" with some_email

... look for templates/some_email.eex next to the behaviour file and then evaluate the template with (hand-waving-alert) the context.

Other actions I'd thought of were:

Then broadcast broadcast_msg
Then return return_msg
Then SMS sms_msg
Then refer to "infectioncontrol"

...where:

  • Broadcast == Websockets pubsub channel that anything can subscribe to
  • Return == Send message to the endpoint supplied with the original incoming event
  • SMS == Twillio
  • All of these are looking for templates

Refer to would hit the API from opal-referral

@rossjones
Copy link
Contributor Author

Have implemented the stubs for these in Ddd.Actions which can use the submodules to actually do the work :). Not sure if you want to leave this open until they actually do something more than just success.

davidmiller added a commit that referenced this issue Oct 18, 2014
@davidmiller
Copy link
Member

Have implemented Return && Email.

I'd say that's enough for this one && let's create tickets for the other 3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants