Fix for issue #456 #457
Merged
Fix for issue #456 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
silabs-oysteink
commented
May 24, 2023
silabs-oysteink
commented
- Changed when the counter for issued instructions are reset.
- Some logic that was used to reset counters (through ctrl_fsm.allow_dummy_instr) was instead moved to factor into dummy_insert_o without resetting the counter)
- Changed how we count instructions (counting when the first operation of an instruction goes from IF to ID, excluding pointers)
Refactored when dummies are allowed to insert and when the counter for issued instructions are reset. Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
…ompletes with last_op. Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
silabs-oysteink
added
the
Component:RTL
Silabs-ArjanB
requested changes
May 24, 2023
| @@ -913,7 +913,9 @@ module cv32e40s_rvfi | |||
| if (is_dummy_instr_wb_i) begin | |||
| dummy_suppressed_intr <= in_trap[STAGE_WB] || dummy_suppressed_intr; | |||
| end else begin | |||
| dummy_suppressed_intr <= 1'b0; | |||
| if (last_op_wb_i) begin | |||
There was a problem hiding this comment.
This needs explanation
There was a problem hiding this comment.
Added comments
| @@ -676,17 +676,23 @@ module cv32e40s_if_stage import cv32e40s_pkg::*; | |||
| generate | |||
| if (DUMMY_INSTRUCTIONS) begin : gen_dummy_instr | |||
| logic instr_issued; // Used to count issued instructions between dummy instructions | |||
| assign instr_issued = if_valid_o && id_ready_i; | |||
|
|
|||
| // Count instructions when first_op==1 to not count suboperations of sequences | |||
There was a problem hiding this comment.
Explain why it is important to use first_op as opposed to last_op
There was a problem hiding this comment.
Added explanation
Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
Silabs-ArjanB
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.