Skip to content

Commit

Permalink
Merge pull request #908 from silabs-oysteink/silabs-oysteink_sequence…
Browse files Browse the repository at this point in the history
…r-todo

Removed two todo's in the sequencer.
  • Loading branch information
Silabs-ArjanB committed Aug 11, 2023
2 parents 49c6010 + 7bd4588 commit d3f9552
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions rtl/cv32e40x_sequencer.sv
Expand Up @@ -218,7 +218,6 @@ module cv32e40x_sequencer import cv32e40x_pkg::*;
// In principle this is the same as "seq_en && valid_i"
// as the output of the above decode logic is equivalent to seq_en
// We have valid outputs for any correctly decoded instruction, or when we are handling a tablejump pointer.
// todo: halting IF stage would imply !valid, can this be an issue?
assign valid_o = ((seq_instr != INVALID_INST) || instr_is_tbljmp_ptr_i) && valid_i && !halt_i && !kill_i;


Expand Down Expand Up @@ -328,7 +327,6 @@ module cv32e40x_sequencer import cv32e40x_pkg::*;
end

end
// todo: Any instruction output while not in S_IDLE should not combinatorially depend on instr_rdata_i
S_PUSH: begin
seq_first_fsm = 1'b0;
// sw rs2, current_stack_adj(sp)
Expand Down

0 comments on commit d3f9552

Please sign in to comment.