Added missing signals to rvfi_mem documentation. #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em_memtype to the RVFI chapter of the user manual. Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
silabs-oysteink
added
the
Component:Doc
Silabs-ArjanB
requested changes
Sep 14, 2023
|
|
||
| Instructions will populate the ``rvfi_mem`` outputs with incrementing ``NMEM``, starting at ``NMEM=1``. | ||
|
|
||
| Instructions with a single memory operation (e.g. all RV32I instructions), including split misaligned transfers, will only use NMEM = 1. | ||
| Instructions with multiple memory operations (e.g. the push and pop instructions from Zcmp) use NMEM > 1 in case multiple memory operations actually occur. | ||
| ``rvfi_mem_prot`` indicates the value of OBI prot used for the memory access or accesses. Note that this will be undefined upon access faults. | ||
|
|
||
| ``rvfi_mem_memtype`` indicates the memory type attributes associated with each memory operation (i.e cacheable or bufferable). | ||
| ``rvfi_mem_atop`` indicates the type of atomic transaction as specified in [OPENHW-OBI]_. |
There was a problem hiding this comment.
And how about rvfi_mem_err and rvfi_mem_okay? What are they for and for what transactions do they actually carry valid information? See also #947 and my comments on that one.
There was a problem hiding this comment.
Added explanation for err and exokay as suggested in #947.
Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
Silabs-ArjanB
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added signals rvfi_mem_atop, rvfi_mem_err, rvfi_mem_exokay and rvfi_mem_memtype to the RVFI chapter of the user manual.