Fixes after running SEC vs cv32e40s with SECURE=0. #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored branch_in_ex / branch_taken ex. SEC clean. - Not allowing async debug, interrupts or NMI when csr_flush_ack_q == 1. NOT SEC clean. Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
silabs-oysteink
added
the
Component:RTL
silabs-oysteink
changed the title
Silabs-ArjanB
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #498 on cv32e40s there was a list of required changes to the e40x controller to get to a SEC clean state.
This PR addresses two changes to align the two cores. The first bullet below is just a refactor and is SEC clean.
The second is not SEC clean, and the reasoning here is that without this change the e40x can kill the pipeline for debug or interrupts before a CSR flush handshake is completed (before the jump to the instruction after the CSR is performed).