Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced type for lsu_err_wb #958

Merged
merged 3 commits into from Oct 2, 2023
Merged

Introduced type for lsu_err_wb #958

merged 3 commits into from Oct 2, 2023

Conversation

silabs-oysteink
Copy link
Contributor

SEC clean

@silabs-oysteink
Introduced 'lsu_err_wb_t' for output from the LSU to align with e40s.
34226e8 
SEC clean.

Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
@silabs-oysteink
Updated usage of lsu_err_wb_i in RVFI to reflect changing to a type i…
24f209a 
…nstead of logic.

Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
@silabs-oysteink
Comment updates.
9545523 
Signed-off-by: Oystein Knauserud <Oystein.Knauserud@silabs.com>
@silabs-oysteink silabs-oysteink added the Component:RTL For issues in the RTL (e.g. for files in the rtl directory) label Oct 2, 2023
silabs-robin
silabs-robin reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does hello world pass and is formal prop still functional?

@silabs-oysteink
Copy link
Contributor Author

ci_check passes and formal prop seems good to me.

@Silabs-ArjanB Silabs-ArjanB merged commit 3950a86 into openhwgroup:master Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silabs-robin silabs-robin silabs-robin left review comments

@Silabs-ArjanB Silabs-ArjanB Silabs-ArjanB approved these changes

Assignees
No one assigned
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@silabs-oysteink @Silabs-ArjanB @silabs-robin