Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extended hpdc cache subsystem #1978

Closed
wants to merge 11 commits into from
Closed

feat: extended hpdc cache subsystem #1978

wants to merge 11 commits into from
+1,867 −3

Conversation

takeshiho0531
Copy link
Contributor

@takeshiho0531 takeshiho0531 commented Mar 31, 2024 •
edited

WHAT

detail

  • axi arbiter for extended hpdc

HOW to extend hpdcache

  • High Performance Instruction Cache:
    • instruction cache with 3-stage pipeline, Replay Table and MSHR
    • based on the original hpdcache code, remove the module for the write buffer part and the signals that control it, plus the module for the uncacheable write part and the signals that control it
    • the depth of Replay Table and MSHR will be decided through performance evaluation (reason: The utilization of the instruction cache is dependent on the capability of instruction fetch.)
  • replace current cva6_icache in cva6_hpdcache_subsystem.sv by High Performance Instruction Cache

github-actions[bot]
github-actions bot reviewed Mar 31, 2024
View reviewed changes
core/cache_subsystem/extended_hpdcache_subsystem_axi_arbiter.sv Outdated
output logic icache_miss_ready_o,
input logic icache_miss_valid_i,
input hpdcache_mem_req_t icache_miss_i,
input hpdcache_mem_id_t icache_miss_id_i,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
input hpdcache_mem_id_t icache_miss_id_i,
input hpdcache_mem_id_t icache_miss_id_i,

@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

@MikeOpenHWGroup
Copy link
Member

Thanks for the contribution @takeshiho0531! I have left a few comments and will leave it to other members of the team to review/approve this PR.

In addition to the specific comments, it would be very good indeed if you could provide a markdown (rst) file documenting how you have extend hpdcache so that it can be used as an I$.

@JeanRochCoulon JeanRochCoulon added the Status:Do-not-merge Pull request that should not be merged (yet) label Apr 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

github-actions[bot]
github-actions bot reviewed May 18, 2024
View reviewed changes
core/cache_subsystem/hpdcache_dcache_with_adapter.sv Outdated Show resolved Hide resolved
core/cache_subsystem/hpdcache_dcache_with_adapter.sv Outdated Show resolved Hide resolved
core/cache_subsystem/hpdcache_dcache_with_adapter.sv Show resolved Hide resolved
core/cache_subsystem/hpdcache_dcache_with_adapter.sv Show resolved Hide resolved
core/cache_subsystem/hpdcache_dcache_with_adapter.sv Outdated Show resolved Hide resolved
core/cache_subsystem/hpdcache_icache_with_adapter.sv Show resolved Hide resolved
core/cache_subsystem/hpdcache_icache_with_adapter.sv Show resolved Hide resolved
core/cache_subsystem/hpdcache_icache_with_adapter.sv Outdated Show resolved Hide resolved
core/cache_subsystem/hpdcache_icache_with_adapter.sv Outdated Show resolved Hide resolved
core/cache_subsystem/hpdcache_icache_with_adapter.sv Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

github-actions[bot]
github-actions bot reviewed May 18, 2024
View reviewed changes
core/cache_subsystem/extended_hpdcache_subsystem.sv Outdated Show resolved Hide resolved
core/cache_subsystem/extended_hpdcache_subsystem.sv Outdated Show resolved Hide resolved
core/cache_subsystem/extended_hpdcache_subsystem.sv Outdated Show resolved Hide resolved
core/cache_subsystem/extended_hpdcache_subsystem.sv Outdated Show resolved Hide resolved
core/cache_subsystem/extended_hpdcache_subsystem.sv Outdated Show resolved Hide resolved
core/cache_subsystem/extended_hpdcache_subsystem.sv Outdated Show resolved Hide resolved
core/cache_subsystem/extended_hpdcache_subsystem.sv Outdated Show resolved Hide resolved
core/cache_subsystem/extended_hpdcache_subsystem.sv Outdated Show resolved Hide resolved
core/cache_subsystem/hpdcache_dcache_with_adapter.sv Outdated Show resolved Hide resolved
core/cache_subsystem/hpdcache_icache_with_adapter.sv Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

github-actions[bot]
github-actions bot reviewed May 25, 2024
View reviewed changes
core/cva6.sv Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

@takeshiho0531 takeshiho0531 mentioned this pull request May 31, 2024
Merged
@JeanRochCoulon
Copy link
Contributor

@takeshiho0531 THis PR is open for a while. What is his status? If not needed for cva6 project, please close it.

@takeshiho0531 takeshiho0531 deleted the feat-extended_hpdc branch June 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@JeanRochCoulon JeanRochCoulon Awaiting requested review from JeanRochCoulon JeanRochCoulon will be requested when the pull request is marked ready for review JeanRochCoulon is a code owner

@zarubaf zarubaf Awaiting requested review from zarubaf zarubaf will be requested when the pull request is marked ready for review zarubaf is a code owner

Assignees
No one assigned
Labels
Status:Do-not-merge Pull request that should not be merged (yet)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takeshiho0531 @MikeOpenHWGroup @JeanRochCoulon