Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent reset address #110

Open
NignetShark opened this issue Apr 3, 2023 · 3 comments
Open

Inconsistent reset address #110

NignetShark opened this issue Apr 3, 2023 · 3 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@NignetShark
Copy link

Bug Description

I noticed that reset address was moved from boot_addr + 0x80 to boot_addr + 0x0 but some files are still using the old address, such as :

  • sw/simple_system/common/ctr0.S, line 100 :
// reset vector
.org 0x80
jal x0, reset_handler
  • sw/simple_system/common/link.ld, line 22 :
_entry_point = _vectors_start + 0x80;

I don't know if it's a legacy from the Ibex documentation but doc/03_reference/exception_interrupts.rst and doc/02_user/integration.rst still refer to the old reset address which might be misleading.

@davideschiavone
Copy link

hello @NignetShark , it's definitively legacy code, not sure yet what the cve2 team will do with those SW files, if removing them or fixing @christian-herber-nxp

@christian-herber-nxp
Copy link

Decision is that reset address will be 0. this should be fixed in the files pointed out.

@davideschiavone davideschiavone added bug Something isn't working documentation Improvements or additions to documentation labels Jun 2, 2023
@szbieg
Copy link

szbieg commented Jun 7, 2023

I have no way to test the requested modification of the crt0.S as the current test environment is using bare-metal-programs using the bsp/crt0.S.

@szbieg szbieg removed their assignment Jun 7, 2023
szbieg added a commit to NXP/openhwgroup-cve2 that referenced this issue Jun 9, 2023
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
szbieg added a commit to NXP/openhwgroup-cve2 that referenced this issue Jun 19, 2023
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
szbieg added a commit to NXP/openhwgroup-cve2 that referenced this issue Jun 19, 2023
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
szbieg added a commit to NXP/openhwgroup-cve2 that referenced this issue Jun 19, 2023
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
szbieg added a commit to NXP/openhwgroup-cve2 that referenced this issue Jun 19, 2023
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: No status
Development

No branches or pull requests

4 participants