Keep bit-manipulation extension control option as localparam #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davideschiavone
requested changes
Feb 13, 2023
| @@ -66,15 +66,15 @@ Other blocks use the ALU for the following tasks: | |||
|
|
|||
| Bit-Manipulation Extension | |||
| Support for the `RISC-V Bit-Manipulation Extension version 1.0.0 <https://github.com/riscv/riscv-bitmanip/releases/download/1.0.0/bitmanip-1.0.0-38-g865e7a7.pdf>`_ and `draft version 0.93 from January 10, 2021 <https://github.com/riscv/riscv-bitmanip/blob/master/bitmanip-0.93.pdf>`_ is optional. [#B_draft]_ | |||
| It can be enabled via the enumerated parameter ``RV32B`` defined in :file:`rtl/cve2_pkg.sv`. | |||
| It can be enabled via the enumerated local parameter ``RV32B`` defined in :file:`rtl/cve2_pkg.sv`. | |||
There was a problem hiding this comment.
we should say that we as OpenHW Group do not maintain the RVB extensions, therefor users are responsible to fork the core and enable the parameter at their own risk in their fork, so that it is clear that these ISA extensions won't be at high TRL, nor maintained by OpenHW Group
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
christian-herber-nxp
force-pushed
the
feature/keep_rv32b_as_localparam
branch
from
4d74b22
to
269e037
Compare
davideschiavone
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Szymon Bieganski szymon.bieganski@oss.nxp.com