Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove writeback stage #56

Merged
merged 10 commits into from May 31, 2023
Merged

Feature/remove writeback stage #56

merged 10 commits into from May 31, 2023

Conversation

christian-herber-nxp
Copy link

No description provided.

github-actions[bot]
github-actions bot reviewed Feb 14, 2023
View reviewed changes
rtl/cve2_controller.sv Outdated Show resolved Hide resolved
rtl/cve2_wb.sv Outdated Show resolved Hide resolved
davideschiavone
davideschiavone reviewed Feb 14, 2023
View reviewed changes
rtl/cve2_core.sv Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Feb 15, 2023
View reviewed changes
rtl/cve2_id_stage.sv Outdated Show resolved Hide resolved
rtl/cve2_core.sv Show resolved Hide resolved
rtl/cve2_core.sv Show resolved Hide resolved
rtl/cve2_core.sv Show resolved Hide resolved
@christian-herber-nxp christian-herber-nxp marked this pull request as draft March 1, 2023 11:45
github-actions[bot]
github-actions bot reviewed Mar 2, 2023
View reviewed changes
rtl/cve2_core.sv Outdated Show resolved Hide resolved
@christian-herber-nxp christian-herber-nxp marked this pull request as ready for review March 3, 2023 16:08
@christian-herber-nxp christian-herber-nxp force-pushed the feature/remove_WritebackStage branch 2 times, most recently from f799b6d to ce4bd1e Compare March 3, 2023 16:17
@christian-herber-nxp
Copy link
Author

@davideschiavone re-review is needed

@christian-herber-nxp
Copy link
Author

@davideschiavone branch was updated after rebase.

@szbieg
remove parameter option WritebackStage
9628c9f 
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@szbieg
remove references to the removed parameters from examples
87530a0 
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@szbieg
remove references to the removed parameters from compliance verification
7843626 
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@szbieg
remove references to the removed parameters from formal verification …
6dc01d6 
…code generated for SymbioticEDA

Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@szbieg
Remove reference to the deleted parameterd from the documentation
d5f280c 
Do not refer to WriteBack as to a stage

Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@szbieg
Remove related code to Writeback stage
fd0c56b 
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@szbieg
Removal of related and dead code after Writeback-stage removal
6886d67 
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@szbieg
substitute ASSERT macro with one ignoring rst_ni and clk signals
ab68511 
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@davideschiavone
Copy link

davideschiavone commented May 25, 2023 •
edited

  • merge master in/rebase
  • Sequential Equivalent Check PASS
  • sec.sh script to be updated as well to waive test_i from the cve2_top module
  • rewrite cve2_wb assertion without depending from rst_ni/clk_i

@szbieg
keep clk_i and rst_ni for the sake of assert alone
ec7cc29 
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@davideschiavone davideschiavone mentioned this pull request May 25, 2023
Merged
@szbieg
BUGFIX: reintroduce en_wb signal between id and wb
cec27cb 
Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
@davideschiavone davideschiavone merged commit 3a9f2d0 into openhwgroup:main May 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@davideschiavone davideschiavone Awaiting requested review from davideschiavone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christian-herber-nxp @davideschiavone @szbieg