Relocate RegFile from TOP level to CORE level #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davideschiavone : Could you please review this? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -887,8 +824,28 @@ module cve2_core import cve2_pkg::*; #( | |||
| //////////////////////// | |||
| // RF (Register File) // | |||
| //////////////////////// | |||
| `ifdef RVFI | |||
| `endif | |||
| begin : gen_regfile_ff | |||
There was a problem hiding this comment.
Module-level begin-end blocks are not LRM-valid syntax. [Style: floating-begin-end-blocks] [module-begin-block]
Remove dead and related code Signed-off-by: Szymon Bieganski <szymon.bieganski@oss.nxp.com>
christian-herber-nxp
force-pushed
the
feature/move_regfile_into_core
branch
from
98d866a
to
eeab54d
Compare
| @@ -346,10 +256,6 @@ module cve2_top import cve2_pkg::*; #( | |||
|
|
|||
| end | |||
|
|
|||
| assign alert_major_internal_o = core_alert_major; | |||
There was a problem hiding this comment.
shall we remove them from the interface as well?
davideschiavone
requested changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dead and related code