Remove scope from the token refresh request as it is redundant
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scope is a valid parameter for the Refresh Token request (Sectiom 6 of RFC 6749), however it's optional and when ommitted is treated as equal to the scope originally granted by the resource owner. Since the indented behavior of this convenience method is to create a token refresh with the full scope, it's redundant to include. Related to b5870c0 but slightly different reason.
WilliamDenniss
force-pushed
the
noscope
branch
from
12b0cfe
to
e7077f1
Compare
Codecov Report
@@ Coverage Diff @@
## pre1.0 #301 +/- ##
=======================================
Coverage 74.02% 74.02%
=======================================
Files 58 58
Lines 4981 4981
=======================================
Hits 3687 3687
Misses 1294 1294
Continue to review full report at Codecov.
|
|
hello @WilliamDenniss , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope is a valid parameter for the Refresh Token request (Sectiom 6 of RFC
6749), however it's optional and when ommitted is treated as equal to the scope
originally granted by the resource owner. Since the indented behavior of this
convenience method is to create a token refresh with the full scope, it's
redundant to include.
Related to b5870c0 but slightly different
reason.