This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
Fix encoding errors in some POST forms + fix example server #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em if needed)." Since the message values are not URL encoded, calling urldecode() on them does not make sense. Instead, it breaks any OpenID parameter containing anything that looks like URL encoding. This reverts commit 8d53dfe.
Since this data is inserted as strings in HTML documents, we should call htmlspecialchars() to protect against any values containing special characters, e.g. '"' or '&'.
Since all objects are passed by reference in PHP 5, assigning them by reference does not make sense, and in some cases causes warnings.
|
+1 from me and merge. |
marcoceppi
added a commit
that referenced
this pull request
Dec 21, 2012
Fix encoding errors in some POST forms + fix example server
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset contains three fixes: