Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider constraining NWebSec to OpenIddict endpoints #14

Closed
kevinchalet opened this issue Oct 21, 2015 · 11 comments
Closed

Consider constraining NWebSec to OpenIddict endpoints #14

kevinchalet opened this issue Oct 21, 2015 · 11 comments
Labels
Milestone

Comments

@kevinchalet
Copy link
Member

No description provided.

@kevinchalet kevinchalet added this to the 1.0.0-alpha1 milestone Oct 21, 2015
@kevinchalet
Copy link
Member Author

@ilmax @Bartmax still no sign of a port of NWebSec for vNext. Should we simply replace it by something else, that would also work on CoreCLR?

@ilmax
Copy link
Contributor

ilmax commented Nov 9, 2015

Maybe we should ping @klings :)

@klings
Copy link

klings commented Nov 10, 2015

Hey guys, you're well underway with your ASP.NET 5 support? Which NWebsec libraries have you been using, the middleware? ASP.NET 5 support is next in line for NWebsec, but there's no trace of it on GitHub as I've been poking around with the new ASP.NET locally so far.

@kevinchalet
Copy link
Member Author

Hey André (and sorry for the late answer)! 😄

Hey guys, you're well underway with your ASP.NET 5 support?

Actually, OpenIddict is totally new and was designed from scratch for ASP.NET 5, but ASOS (the OpenID Connect library behind this project: https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Server) comes with a default sample that demonstrates how to use NWebSec with ASP.NET 5 for a long time now (more than a year, actually: aspnet-contrib/AspNet.Security.OpenIdConnect.Server@0111029 🎉)

Which NWebsec libraries have you been using, the middleware?

Yep, the main middleware. Ideally, we'd also like to use the MVC adapter, since OpenIddict internally uses a controller to render the critical authorization pages.

ASP.NET 5 support is next in line for NWebsec, but there's no trace of it on GitHub as I've been poking around with the new ASP.NET locally so far.

If you want us to test the early bits, don't hesitate, we're now pretty good at that 😄
(if you have specific questions about ASP.NET 5 or DNX, please feel free to ping me on JabbR: https://jabbr.net/#/rooms/AspNetvNext)

@klings
Copy link

klings commented Dec 6, 2015

I've made progress and the first version of the vnext packages are out. This includes ASP.NET 5 middleware, as well as an updated MVC package. It's a gamma release, as I'll have to make a few minor breaking changes before I'm happy calling it an RC. Still, it works (mostly) as before, and should be safe to "put in production". The middleware is almost identical, but there were a few system.web specific things that had to go in the MVC package.

You can keep an eye on the progress here NWebsec/NWebsec#59 as I make my way to an RC.

Let me know should you run into any issues.

@kevinchalet kevinchalet modified the milestones: 1.0.0-alpha1, 1.0.0-alpha2 Dec 7, 2015
@kevinchalet
Copy link
Member Author

Woooo, it looks really nice, we'll give it a try ASAP! 🎉
Thanks for the info, André.

/cc @damccull

@damccull
Copy link
Contributor

damccull commented Dec 8, 2015

Just waiting on rc2 HTTPS bug to be fixed so I can use it properly. I'll be submitting an issue on it today.

@kevinchalet
Copy link
Member Author

FYI, it's not a bug. See my remark on JabbR 👏

@damccull
Copy link
Contributor

damccull commented Dec 8, 2015

Haha! Looking.

On Tue, Dec 8, 2015, 09:22 Kévin Chalet notifications@github.com wrote:

FYI, it's not a bug. See my remark on JabbR [image: 👏]


Reply to this email directly or view it on GitHub
#14 (comment).

@damccull
Copy link
Contributor

damccull commented Dec 9, 2015

Today we merged in an update using the aspnet5 nwebsec middleware (#37). I'm looking at how to allow OpenIddict users to set the CSP headers themselves.

@kevinchalet
Copy link
Member Author

Closing as invalid (OpenIddict.Security - that used NWebsec - has been removed from the core code base).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants