Update the LinkedIn provider to use "Sign In with LinkedIn V2" #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid the binary breaking change, I decided to keep the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The userinfo endpoint used by the LinkedIn provider points to the unversioned LinkedIn Marketing API that will be removed soon. While it would be easy to use the versioned alternative, this PR goes further by moving from the OAuth 2.0-only "Sign In with LinkedIn" service to the newer OpenID Connect implementation called "Sign In with LinkedIn V2" that offers a standard userinfo endpoint.
Note: this change is binary breaking (given that theIt's also important to note that different claims are returned by the standard OIDC userinfo endpoint.Fieldsoption is being removed).