-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple the EntityFramework adapter from the core project #8
Conversation
.AddDefaultTokenProviders(); | ||
.AddDefaultTokenProviders() | ||
|
||
.AddOpenIddict<ApplicationUser, Application>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not AddOpenIddict<Application>
ApplicationUser is already part of the AddIdentity part, can we use that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Updated 👍
if (application.Type == ApplicationType.Public && !string.IsNullOrEmpty(context.ClientSecret)) { | ||
// Reject tokens requests containing a client_secret | ||
// if the client application is not confidential. | ||
var type = await manager.GetApplicationTypeAsync(application); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: applicationType instead of type
|
Merged. Thanks for the review guys 👍 |
(please note that it's still a WIP 😄)
/cc @Bartmax @ilmax