Create an SPA sample. #8

shaunluttin · 2016-07-26T19:51:09Z

No description provided.

ilmax · 2016-07-26T21:05:53Z

Hy @shaunluttin what the status of this? Looks like a work in progress right? Btw a convention for folder naming was discussed with @PinpointTownes and we agreed on naming the folder corresponding to the implemented flow e.g. ImplicitFlow or ResourceOwnerPasswordCredentials.

We will need to update the current MVC sample folder name accordingly 😄

kevinchalet · 2016-07-26T21:16:10Z

samples/Mvc/Mvc.Server/Startup.cs

@@ -43,6 +43,8 @@ public class Startup {
                .AllowAuthorizationCodeFlow()
                .AllowRefreshTokenFlow()

+                .AddEphemeralSigningKey()


FYI, this missing line was added yesterday. Consider rebasing your PR.

@PinpointTownes Done.

Well, I rebased, but the change still appears. Maybe I didn't understand. My current history:

* b5670a4 (HEAD -> spa-sample, origin/spa-sample) Rename directory to CodeFlow. * 15f9e1d Update readme.md. * 3f3600c Seed a client. * e020005 Obtain OpenID Provider Configuration Information. * 929c423 Add OpenIddict and prerequisites. * dbb7543 Configure WebHost. * c81202e Add README.md. * a43a1e6 Scaffold SPA sample. | * 1b3fccd (origin/mvc-readme, mvc-readme) Create README for running MVC samples. |/ * 4d03982 (upstream/master, origin/master, origin/HEAD, master) React to API changes in OpenIddict * 9d332c0 Copy the MVC sample from the main repository * 2aa39e0 Set up the initial project structure

Alright, looks like you'll have to remove it manually. Please push a new commit to get rid of this duplicate call.

This line is still there? 😄 We really don't want to generate 2 RSA keys at runtime (it takes time and there's no point doing that).

REVERT THAT!!!!!!!!!!!

kevinchalet · 2016-07-26T21:17:57Z

We will need to update the current MVC sample folder name accordingly 😄

Lazy me, I've simply copied the MVC samples as-is without renaming them 😅
Thanks for the heads-up, I'll fix that.

shaunluttin · 2016-07-27T00:15:13Z

@ilmax Definitely a work in progress. Probably about another 20 to 40 hours until completion.

shaunluttin · 2016-07-27T00:17:39Z

@ilmax Thank you for letting me know about the naming convention. Renamed to CodeFlow.

ilmax · 2016-07-27T07:17:05Z

Well done, call me out for a review when your done implementing this

shaunluttin · 2016-07-29T04:56:31Z

@ilmax While it isn't complete, login/logout now both work in a rudimentary fashion. If you have the time, I would love your feedback on the big picture decisions I am making. I.e. Is my overall architecture heading in a reasonable direction?

kevinchalet · 2016-08-06T13:14:32Z

Looks promising. Just one remark: please consider excluding non-source JS files (like typings or external libraries). They add unnecessary noise.

shaunluttin · 2016-08-06T21:16:55Z

@PinpointTownes Done. Thank you for that feedback. 1. I removed the the TypeScript definitions that typings manages. I left the custom_typings though, because they are not external but are my own definitions and are helpful to anyone trying to work with the code. 2. I think that there are no more external libraries there any more. If I'm mistaken, I welcome feedback.

kevinchalet · 2016-08-10T20:48:17Z

samples/ImplicitFlow/AureliaApp/aurelia_project/generators/attribute.json

@@ -0,0 +1,4 @@
+{


@shaunluttin curious: do we need all these "generator files" in the final code?

@PinpointTownes It appears that we do not need them. They are for code generation via the Aurelia CLI. Question: would you delete and purge them from the history too or just delete and commit?

https://www.npmjs.com/package/aurelia-cli#generators

Just delete and commit. The related commits will disappear when squashing (before merging your PR).

kevinchalet · 2016-08-10T20:53:26Z

samples/ImplicitFlow/AuthorizationServer/Startup.cs

+                // Enable the authorization, logout, token and userinfo endpoints.
+                .EnableAuthorizationEndpoint("/connect/authorize")
+                .EnableLogoutEndpoint("/connect/logout")
+                .EnableTokenEndpoint("/connect/token")


Note: the token endpoint is not used for the implicit flow. Consider removing this line to disable it.

kevinchalet · 2016-09-08T21:02:47Z

samples/ImplicitFlow/ResourceServer01/Controllers/ResourceController.cs

+
+namespace ResourceServer01.Controllers
+{
+    [Route("")]


There are still weird empty routes.

It's the simplest way that I know for having an action handle the empty route.

kevinchalet · 2016-09-10T07:46:39Z

FYI, there are still a bunch of missing NPM modules: through2, minimatch and source-map.

kevinchalet · 2016-09-10T07:49:58Z

samples/ImplicitFlow/ResourceServer01/Startup.cs

+                options.ClientSecret = "secret_secret_secret";
+            });
+
+            app.UseStatusCodePagesWithReExecute("/error");


Don't forget to kill that.

kevinchalet · 2016-09-10T07:53:52Z

Alright, looks like it's almost ready. Please fix the missing modules (flush your node_modules and restore everything before pushing to ensure nothing's missing) and the 2 or 3 nits I just added and I'll merge your PR today or tomorrow 👏

Thanks for this great contribution.

shaunluttin · 2016-09-16T00:27:37Z

I've run git clean -xfd and also deleted ~\AppData\Roaming\npm.

I've also run the following, because git was not able to delete those deep node_modules.

Get-ChildItem -Recurse -Directory -Depth 5 | `
    ? { $_.Name -eq "node_modules" } | `
    % { rimraf $_.FullName }

Despite all that, I'm not missing any dependencies when running the demo. It might have to do with your node version. These are mine:

> node -v
v6.3.0
> npm -v 
3.10.3

I'll try running it on my spouses computer later tonight.

kevinchalet · 2016-09-22T22:41:56Z

Merged, thanks for this great sample! 5971adc

kevinchalet reviewed Jul 26, 2016
View reviewed changes

kevinchalet added the enhancement label Jul 26, 2016

kevinchalet self-assigned this Jul 26, 2016

shaunluttin force-pushed the spa-sample branch from 38dfd0c to 597e4d8 Compare July 26, 2016 21:45

shaunluttin force-pushed the spa-sample branch from 5f26144 to b5670a4 Compare July 27, 2016 00:25

shaunluttin force-pushed the spa-sample branch from 09f5880 to 16d0323 Compare July 28, 2016 22:54

kevinchalet mentioned this pull request Jul 30, 2016

Add sample where resource server is separate from auth server openiddict/openiddict-core#180

Closed

shaunluttin force-pushed the spa-sample branch 2 times, most recently from ffd3e3e to 94e899f Compare August 4, 2016 00:02

shaunluttin force-pushed the spa-sample branch 8 times, most recently from 645e9e7 to aea0c73 Compare August 10, 2016 18:54

kevinchalet reviewed Aug 10, 2016
View reviewed changes

shaunluttin force-pushed the spa-sample branch from 88b7614 to a54b182 Compare August 10, 2016 20:51

kevinchalet reviewed Aug 10, 2016
View reviewed changes

kevinchalet reviewed Sep 8, 2016
View reviewed changes

shaunluttin force-pushed the spa-sample branch 2 times, most recently from 6b61a73 to 8b32560 Compare September 9, 2016 04:45

kevinchalet reviewed Sep 10, 2016
View reviewed changes

shaunluttin force-pushed the spa-sample branch 2 times, most recently from 111f731 to 16b59a4 Compare September 22, 2016 18:27

Create an implicit flow sample

44fface

shaunluttin force-pushed the spa-sample branch from 16b59a4 to 44fface Compare September 22, 2016 18:46

kevinchalet closed this Sep 22, 2016

shaunluttin deleted the spa-sample branch September 25, 2016 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create an SPA sample. #8

Create an SPA sample. #8

shaunluttin commented Jul 26, 2016

ilmax commented Jul 26, 2016

kevinchalet Jul 26, 2016

shaunluttin Jul 27, 2016 •

edited

kevinchalet Aug 6, 2016

kevinchalet Sep 3, 2016

kevinchalet Sep 8, 2016

kevinchalet commented Jul 26, 2016

shaunluttin commented Jul 27, 2016

shaunluttin commented Jul 27, 2016

ilmax commented Jul 27, 2016

shaunluttin commented Jul 29, 2016

kevinchalet commented Aug 6, 2016

shaunluttin commented Aug 6, 2016 •

edited

kevinchalet Aug 10, 2016

shaunluttin Aug 10, 2016 •

edited

kevinchalet Aug 10, 2016

kevinchalet Aug 10, 2016

kevinchalet Sep 8, 2016

shaunluttin Sep 9, 2016

kevinchalet commented Sep 10, 2016

kevinchalet Sep 10, 2016

kevinchalet commented Sep 10, 2016

shaunluttin commented Sep 16, 2016 •

edited

kevinchalet commented Sep 22, 2016

Create an SPA sample. #8

Create an SPA sample. #8

Conversation

shaunluttin commented Jul 26, 2016

ilmax commented Jul 26, 2016

Choose a reason for hiding this comment

shaunluttin Jul 27, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinchalet commented Jul 26, 2016

shaunluttin commented Jul 27, 2016

shaunluttin commented Jul 27, 2016

ilmax commented Jul 27, 2016

shaunluttin commented Jul 29, 2016

kevinchalet commented Aug 6, 2016

shaunluttin commented Aug 6, 2016 • edited

Choose a reason for hiding this comment

shaunluttin Aug 10, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinchalet commented Sep 10, 2016

Choose a reason for hiding this comment

kevinchalet commented Sep 10, 2016

shaunluttin commented Sep 16, 2016 • edited

kevinchalet commented Sep 22, 2016

shaunluttin Jul 27, 2016 •

edited

shaunluttin commented Aug 6, 2016 •

edited

shaunluttin Aug 10, 2016 •

edited

shaunluttin commented Sep 16, 2016 •

edited