Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OE0-18: Replace internal FHIR model with fhir.resources library #25

Merged
merged 15 commits into from Jul 13, 2021

Conversation

sniedzielski
Copy link
Contributor

Ticket: https://openimis.atlassian.net/browse/OE0-18

Required fixes after developing this ticket (detected errors during development after connecting models from 'fhir.resources' repository)

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2021

This pull request introduces 25 alerts and fixes 10 when merging e7e31a7 into b9f16b6 - view on LGTM.com

new alerts:

  • 9 for Module imports itself
  • 9 for Variable defined multiple times
  • 5 for Unused local variable
  • 2 for Unused import

fixed alerts:

  • 8 for Unused import
  • 1 for `__eq__` not overridden when adding attributes
  • 1 for Unused local variable

@dragos-dobre dragos-dobre merged commit b94cdde into develop Jul 13, 2021
@dragos-dobre dragos-dobre deleted the feature/OE0-18 branch July 13, 2021 14:20
@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2021

This pull request introduces 33 alerts and fixes 16 when merging 65bc04e into b9f16b6 - view on LGTM.com

new alerts:

  • 10 for Unused import
  • 9 for Module imports itself
  • 9 for Variable defined multiple times
  • 5 for Unused local variable

fixed alerts:

  • 14 for Unused import
  • 1 for `__eq__` not overridden when adding attributes
  • 1 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants