Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPL-58: Add authorization to Subscription endpoints (owner/permissions) #85

Merged
merged 2 commits into from Mar 15, 2022
Merged

OPL-58: Add authorization to Subscription endpoints (owner/permissions) #85

merged 2 commits into from Mar 15, 2022

Conversation

malinowskikam
Copy link
Contributor

https://openimis.atlassian.net/browse/OPL-58
This PR depends on #84

Changes:

  • Added subscription permission group (CRUD) and assigned them to respective actions
  • Added validation to resource requested by the subscription (Does the user have permissions to read the resources)

@lgtm-com
Copy link

lgtm-com bot commented Feb 22, 2022

This pull request introduces 1 alert when merging 08c87c9 into 29a3e32 - view on LGTM.com

new alerts:

  • 1 for Unused import

Base automatically changed from feature/OPL-55 to develop February 23, 2022 11:09
@lgtm-com
Copy link

lgtm-com bot commented Feb 23, 2022

This pull request introduces 1 alert when merging 08c87c9 into 1165317 - view on LGTM.com

new alerts:

  • 1 for Unused import

dborowiecki
dborowiecki reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@dborowiecki dborowiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've left some ideas for improvement.

api_fhir_r4/converters/subscriptionConverter.py Outdated Show resolved Hide resolved
api_fhir_r4/serializers/subscriptionSerializer.py Outdated Show resolved Hide resolved
api_fhir_r4/serializers/subscriptionSerializer.py Outdated Show resolved Hide resolved
api_fhir_r4/serializers/subscriptionSerializer.py Show resolved Hide resolved
api_fhir_r4/validation.py Outdated Show resolved Hide resolved
api_fhir_r4/views/fhir/subscription.py Outdated Show resolved Hide resolved
api_fhir_r4/views/fhir/subscription.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Mar 14, 2022

This pull request introduces 1 alert when merging 9ff331a into 67f4eea - view on LGTM.com

new alerts:

  • 1 for Unused import

@malinowskikam
Copy link
Contributor Author

@dborowiecki I applied the changes

@lgtm-com
Copy link

lgtm-com bot commented Mar 14, 2022

This pull request introduces 1 alert when merging 7e9e50e into 67f4eea - view on LGTM.com

new alerts:

  • 1 for Unused import

@delcroip
Copy link
Member

@dborowiecki , @malinowskikam please resolve the conversation that need to be

br

@dragos-dobre dragos-dobre merged commit fa59715 into develop Mar 15, 2022
@dragos-dobre dragos-dobre deleted the feature/OPL-58 branch March 15, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragos-dobre dragos-dobre dragos-dobre approved these changes

@sniedzielski sniedzielski Awaiting requested review from sniedzielski

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@malinowskikam @delcroip @dragos-dobre @dborowiecki