OAI-63: Improve contained resources and converters #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 58fc5b5 into 914a98b - view on LGTM.com new alerts:
|
|
|
||
| @classmethod | ||
| def build_fhir_medication_frequency_extension(cls, value): | ||
| # TODO: Is this ok? Value is assigned to period instead of frequency |
There was a problem hiding this comment.
| @@ -20,13 +21,14 @@ def create(self, validated_data): | |||
| return Service.objects.create(**copied_data) | |||
|
|
|||
| def update(self, instance, validated_data): | |||
| # TODO: This doesn't work, when called from contained resources update creates new entity with same uuid | |||
There was a problem hiding this comment.
Please create a ticket for this in E0 project.
| @@ -25,6 +25,7 @@ def create(self, validated_data): | |||
| return new_family | |||
|
|
|||
| def update(self, instance, validated_data): | |||
| # TODO: This doesn't work | |||
There was a problem hiding this comment.
Please create a ticket for this in E0 project.
dragos-dobre
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to make communication with with claim AI Server: