Test Technical user mixed tech and core users #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires an update of the core for the test helper
edarchis
force-pushed
the
fix_test_user
branch
from
3c7f92a
to
0b27afd
Compare
The "is not" notation shouldn't be used with string literals. This was showing warnings in the console when running the tests.
|
This pull request fixes 4 alerts when merging 3b21e82 into cb011f2 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 4 alerts when merging 75ab6c3 into cb011f2 - view on LGTM.com fixed alerts:
|
delcroip
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires an update of the core for the test helper.
The
if not User.objects.filter(username='admin').exists():was creating a technical user and then fetching a core user with the same username. Instead of just creating the core user, I added a test helper for technical (super) users and this works a lot better.The main project had many test failures because of this.