OFS-96: request to merge what has been started so as to enable to work graphQL PolicyHolder on 'develop' branch #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules naming convention
|
This pull request introduces 4 alerts when merging ecb4b4a into 0799aae - view on LGTM.com new alerts:
|
delcroip
approved these changes
Dec 1, 2020
|
|
||
| user_updated = models.ForeignKey(core_models.InteractiveUser, db_column="UserUpdatedUUID", | ||
| user_updated = models.ForeignKey(core_models.User, db_column="UserUpdatedUUID", null=True, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In that pull request I want to merge to 'develop' branch of this repository a changes related to what Damian @dborowiecki has started.
Without that changes the PolicyHolder queries and mutations doesn't work. But with the schema in ContributionPlan etc the graphQl works properly. It must be implemented even if models haven't been updated yet. I will do it later after ending services in PolicyHolder module.
I also use graphQl base mutations from Core module. It will be used later during developing ContributionPlan module.
Moreover I will make changes with models and graphQL (according to the new model) on another tickets related with ending what Damian started. Also I added migrations file so as to another developers don't have a problems with applying migrations in django on localhost/docker container.