CM-313: Tasks are not created after benefit plan update #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Update for openimis-be-tasks_management_py
dborowiecki
requested changes
Sep 21, 2023
There was a problem hiding this comment.
I don't quite understand this change. Is there a need to create one empty dict and returning it globally? I don't think that's safe and could lead to unexpected results.
For instance, if someone will add key to EMPTY_DICT outside of service then service results will be afected. Shouldn't we create instance of dict in here instead?
|
You are right. Just removed EMPTY_DICT const. You can re-check |
|
Kudos, SonarCloud Quality Gate passed! |
dborowiecki
approved these changes
Sep 21, 2023
sniedzielski
added a commit
that referenced
this pull request
Sep 29, 2023
* CM-313: Tasks are not created after benefit plan update (#18) * CI update * CI Update 2 * CM-313: fixing creation of tasks - no longer json_ext as type * CM-313: removed EMPTY_DICT and changed to {} --------- Co-authored-by: Damian Borowiecki <dborowiecki@soldevelo.com> Co-authored-by: Jan <jdolkowski@soldevelo.com> * CM-327: connects tasks and mutations --------- Co-authored-by: sniedzielski <52816247+sniedzielski@users.noreply.github.com> Co-authored-by: Damian Borowiecki <dborowiecki@soldevelo.com> Co-authored-by: Jan <j.dolkowski@soldevelo.com>
delcroip
added a commit
that referenced
this pull request
Oct 2, 2023
CM-313: Tasks are not created after benefit plan update (#18)
dragos-dobre
added a commit
that referenced
this pull request
Oct 18, 2023
* CI update * CI Update 2 * Added update job (#19) * CM-327: connect tasks and mutations (#20) * CM-313: Tasks are not created after benefit plan update (#18) * CI update * CI Update 2 * CM-313: fixing creation of tasks - no longer json_ext as type * CM-313: removed EMPTY_DICT and changed to {} --------- Co-authored-by: Damian Borowiecki <dborowiecki@soldevelo.com> Co-authored-by: Jan <jdolkowski@soldevelo.com> * CM-327: connects tasks and mutations --------- Co-authored-by: sniedzielski <52816247+sniedzielski@users.noreply.github.com> Co-authored-by: Damian Borowiecki <dborowiecki@soldevelo.com> Co-authored-by: Jan <j.dolkowski@soldevelo.com> --------- Co-authored-by: Damian Borowiecki <dborowiecki@soldevelo.com> Co-authored-by: Jan <jdolkowski@soldevelo.com> Co-authored-by: Damian Borowiecki <dborowiecki7@gmail.com> Co-authored-by: sniedzielski <52816247+sniedzielski@users.noreply.github.com> Co-authored-by: Jan <j.dolkowski@soldevelo.com> Co-authored-by: Patrick Delcroix <delcroip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: https://openimis.atlassian.net/browse/CM-313
Issue caused by having json_ext as type, not dict