Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-313: Tasks are not created after benefit plan update #18

Merged
merged 5 commits into from
Sep 21, 2023
Merged

CM-313: Tasks are not created after benefit plan update #18

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12c557a
CI update
dborowiecki Sep 19, 2023
1ca3b02
CI Update 2
dborowiecki Sep 19, 2023
66e00d4
Merge pull request #17 from openimis/ci_update
jdolkowski Sep 19, 2023
0880d72
CM-313: fixing creation of tasks - no longer json_ext as type
sniedzielski Sep 20, 2023
29382eb
CM-313: removed EMPTY_DICT and changed to {}
sniedzielski Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Module CI
on:
pull_request:
types: [opened, synchronize, reopened]
push:
branches:
- main
- 'release/**'
- develop
- 'feature/**'
workflow_dispatch:
inputs:
comment:
description: Just a simple comment to know the purpose of the manual build
required: false

jobs:
call:
name: Default CI Flow
uses: openimis/openimis-be_py/.github/workflows/ci_module.yml@develop
secrets:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
with:
SONAR_PROJECT_KEY: openimis_openimis-be-tasks_management_py
SONAR_ORGANIZATION: openimis-1
SONAR_PROJECT_NAME: openimis-be-tasks_management_py
SONAR_PROJECT_VERSION: 1.0
SONAR_SOURCES: tasks_management
SONAR_EXCLUSIONS: "**/migrations/**,**/static/**,**/media/**,**/tests/**"

80 changes: 0 additions & 80 deletions .github/workflows/openmis-module-test-psql.yml
View file
Open in desktop

This file was deleted.

99 changes: 0 additions & 99 deletions .github/workflows/openmis-module-test.yml
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions sonar-project.properties
View file
Open in desktop

This file was deleted.

8 changes: 5 additions & 3 deletions tasks_management/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@

logger = logging.getLogger(__name__)

EMPTY_DICT = {}


class TaskService(BaseService):
OBJECT_TYPE = Task
Expand Down Expand Up @@ -184,7 +186,7 @@ def _adjust_create_task_data(self, obj_data):
return obj_data

def _data_for_json_ext_create(self, obj_data):
return dict
return EMPTY_DICT


class UpdateCheckerLogicServiceMixin(ABC):
Expand Down Expand Up @@ -235,7 +237,7 @@ def _adjust_update_task_data(self, obj_data):
return obj_data

def _data_for_json_ext_update(self, obj_data):
return dict
return EMPTY_DICT


class DeleteCheckerLogicServiceMixin(ABC):
Expand Down Expand Up @@ -286,7 +288,7 @@ def _adjust_delete_task_data(self, obj_data):
return obj_data

def _data_for_json_ext_delete(self, obj_data):
return dict
return EMPTY_DICT


class CheckerLogicServiceMixin(CreateCheckerLogicServiceMixin,
Expand Down