Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #36

Merged
merged 8 commits into from
Sep 14, 2021
Merged

Improvements #36

merged 8 commits into from
Sep 14, 2021

Conversation

qgerome
Copy link
Contributor

@qgerome qgerome commented Aug 31, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2021

This pull request introduces 1 alert when merging 7bf57e2 into ef8216b - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update

Let's use the new Context API from React to propagate the modulesManager deeper in the tree. This API makes it easy to use it in a hook
@lgtm-com
Copy link

lgtm-com bot commented Sep 3, 2021

This pull request introduces 2 alerts when merging aedf7cc into ef8216b - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update
  • 1 for Unused variable, import, function or class

Loading & Error states are now displayed on top of the table
Add useful hooks:
* usePrevious : Keep the previous value of the passed argument
* useGraphqlQuery : Trigger a graphql query using redux and returns the result
@lgtm-com
Copy link

lgtm-com bot commented Sep 3, 2021

This pull request introduces 1 alert and fixes 1 when merging 25d30d9 into ef8216b - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update

fixed alerts:

  • 1 for Unneeded defensive code

@edarchis edarchis merged commit 27d256f into develop Sep 14, 2021
@edarchis edarchis deleted the improvements branch September 14, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants