Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OM-54: modal and picker implementation #78

Merged
merged 6 commits into from Oct 31, 2023
Merged

OM-54: modal and picker implementation #78

merged 6 commits into from Oct 31, 2023

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Oct 18, 2023 •
edited

OM-54

REQUIRED PR

Changes:

  • Implementation of Economic Unit modal and picker.
  • Change Picker component to be based on Autocomplete.

@olewandowski1 olewandowski1 mentioned this pull request Oct 18, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@olewandowski1 olewandowski1 marked this pull request as ready for review October 23, 2023 08:29
jdolkowski
jdolkowski approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jdolkowski jdolkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once PR specified as required in the description will be ready I will merge both.

@jdolkowski jdolkowski merged commit 707c124 into develop Oct 31, 2023
3 checks passed
@jdolkowski jdolkowski deleted the feature/OM-54 branch October 31, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolkowski jdolkowski jdolkowski approved these changes

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

@sniedzielski sniedzielski Awaiting requested review from sniedzielski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olewandowski1 @jdolkowski