Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: after modifying the avatar, offline users who joined the group did not synchronize #1198

Merged
merged 11 commits into from
Oct 16, 2023
Merged

fix: after modifying the avatar, offline users who joined the group did not synchronize #1198

merged 11 commits into from
Oct 16, 2023

Conversation

withchao
Copy link
Contributor

@withchao withchao commented Oct 12, 2023 •
edited
Loading


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #909 #1148

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2023
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 12, 2023 •
edited
Loading

Apply Sweep Rules to your PR?

@withchao withchao temporarily deployed to openim October 12, 2023 06:32 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:32 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:32 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:32 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:32 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:32 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:32 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:59 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:59 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:59 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:59 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:59 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:59 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 12, 2023 06:59 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 12, 2023

✨ Created PR: #1199 to fix All new business logic should have corresponding unit tests in the tests/ directory..
This PR was made against the main branch, not your main branch, so it's safe to merge if it looks good!

@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 12, 2023

✨ Created PR: #1200 to fix All new business logic should have corresponding unit tests in the tests/ directory..
This PR was made against the main branch, not your main branch, so it's safe to merge if it looks good!

@withchao withchao requested review from Bloomingg and a team as code owners October 13, 2023 03:22
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2023
@withchao withchao temporarily deployed to openim October 13, 2023 03:22 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 03:22 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 12:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 12:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 12:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 12:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 12:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 12:27 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 12:27 — with GitHub Actions Inactive
@withchao withchao added this pull request to the merge queue Oct 16, 2023
Merged via the queue into openimsdk:main with commit 81cc1f3 Oct 16, 2023
17 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Oct 16, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skiffer-git skiffer-git skiffer-git approved these changes

@cubxxw cubxxw cubxxw approved these changes

@FGadvancer FGadvancer Awaiting requested review from FGadvancer FGadvancer is a code owner

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

Bug: In a group with more than 100 people, there is an exception when changing notes and avatars
3 participants
@withchao @skiffer-git @cubxxw