Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: reduce lock latency for conversation cache #1231

Conversation

rfyiamcool
Copy link
Contributor

summary

The lock granularity here is a bit large, so two-stage locks are used and rpc io operations are handled independently to improve the throughput under cache miss.

Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2023
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 16, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@rfyiamcool rfyiamcool temporarily deployed to openim October 16, 2023 02:37 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 16, 2023 02:37 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 16, 2023 02:37 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 16, 2023 02:37 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 16, 2023 02:37 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 16, 2023 02:37 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 16, 2023 02:37 — with GitHub Actions Inactive
@cubxxw cubxxw enabled auto-merge October 18, 2023 11:47
@cubxxw cubxxw added this pull request to the merge queue Oct 18, 2023
Merged via the queue into openimsdk:main with commit a648bee Oct 18, 2023
22 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Oct 18, 2023
@github-actions github-actions bot added this to the v3.1 milestone Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants