Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the control structure #1294

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Optimize the control structure #1294

merged 3 commits into from
Nov 2, 2023

Conversation

zm50
Copy link
Contributor

@zm50 zm50 commented Oct 30, 2023


🔍 What type of PR is this?

/kind cleanup

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

This PR improves some of the details of the code.

🅰 Which issue(s) this PR fixes:

clean up the code

Fixes #

📝 Special notes for your reviewer:

I suggest reading the corresponding code for better understanding.

🎯 Describe how to verify it

Local verification by fetching my PR through gh or git.
Verification through CICD.
Local verification by running make start.

There are several methods to verify the health of this PR:

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2023
@kubbot
Copy link
Member

kubbot commented Oct 30, 2023

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

@zm50 zm50 temporarily deployed to openim October 30, 2023 01:07 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:07 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:08 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:08 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:08 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 01:08 — with GitHub Actions Inactive
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 30, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1294 (070ba08) into main (a4b28c9) will not change coverage.
The diff coverage is n/a.

❗ Current head 070ba08 differs from pull request most recent head ad14bd1. Consider uploading reports for the commit ad14bd1 to get more accurate results

@@          Coverage Diff          @@
##            main   #1294   +/-   ##
=====================================
  Coverage   2.44%   2.44%           
=====================================
  Files         13      13           
  Lines        778     778           
=====================================
  Hits          19      19           
  Misses       756     756           
  Partials       3       3           
Files Coverage Δ
pkg/common/db/relation/mysql_init.go 20.87% <ø> (ø)

@cubxxw
Copy link
Contributor

cubxxw commented Oct 30, 2023

hi @go75 ,

I would like to kindly request your assistance with two tasks related to our project. Firstly, I would greatly appreciate it if you could sign the Contributor License Agreement (CLA) to ensure that we can use your contributions to the project. Secondly, I would be grateful if you could take a moment to review and address any errors in the Golang lint. Your expertise in this area would be invaluable to the success of our project.

Thank you very much for your time and consideration. Please let me know if you have any questions or concerns.

@zm50
Copy link
Contributor Author

zm50 commented Oct 30, 2023

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@zm50
Copy link
Contributor Author

zm50 commented Oct 30, 2023

I have read the CLA Document and I hereby sign the CLA

@zm50 zm50 temporarily deployed to openim October 30, 2023 03:27 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 03:27 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 03:27 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 03:27 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 03:27 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 03:27 — with GitHub Actions Inactive
@zm50 zm50 temporarily deployed to openim October 30, 2023 03:27 — with GitHub Actions Inactive
@openimbot openimbot added this pull request to the merge queue Nov 2, 2023
Merged via the queue into openimsdk:main with commit 3ce1e6e Nov 2, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 2, 2023
@github-actions github-actions bot added this to the v3.1 milestone Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants