Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the control structure #1294

Merged
merged 3 commits into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/openim-api/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"github.com/OpenIMSDK/protocol/constant"
"github.com/OpenIMSDK/tools/discoveryregistry"
"github.com/OpenIMSDK/tools/log"

"github.com/openimsdk/open-im-server/v3/internal/api"
"github.com/openimsdk/open-im-server/v3/pkg/common/cmd"
"github.com/openimsdk/open-im-server/v3/pkg/common/config"
Expand Down
6 changes: 4 additions & 2 deletions internal/msgtransfer/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ package msgtransfer

import (
"fmt"
"github.com/openimsdk/open-im-server/v3/pkg/common/discovery_register"
"sync"

"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
"sync"

"github.com/openimsdk/open-im-server/v3/pkg/common/discovery_register"

"github.com/OpenIMSDK/tools/mw"

Expand Down
2 changes: 1 addition & 1 deletion internal/rpc/conversation/conversaion.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func (c *conversationServer) SetConversation(ctx context.Context, req *pbconvers
return resp, nil
}

//nolint
// nolint
func (c *conversationServer) SetConversations(ctx context.Context,
req *pbconversation.SetConversationsReq,
) (*pbconversation.SetConversationsResp, error) {
Expand Down
6 changes: 4 additions & 2 deletions internal/tools/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@ package tools
import (
"context"
"fmt"
"github.com/openimsdk/open-im-server/v3/pkg/common/discovery_register"
"math"

"github.com/redis/go-redis/v9"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
"math"

"github.com/openimsdk/open-im-server/v3/pkg/common/discovery_register"

"github.com/OpenIMSDK/tools/errs"
"github.com/OpenIMSDK/tools/log"
Expand Down
2 changes: 1 addition & 1 deletion pkg/apistruct/manage.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type SendMsgReq struct {
type BatchSendMsgReq struct {
SendMsg
IsSendAll bool `json:"isSendAll"`
RecvIDs []string `json:"recvIDs" binding:"required"`
RecvIDs []string `json:"recvIDs" binding:"required"`
}

type BatchSendMsgResp struct {
Expand Down
4 changes: 3 additions & 1 deletion pkg/common/cmd/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ package cmd

import (
"fmt"

"github.com/OpenIMSDK/protocol/constant"
config2 "github.com/openimsdk/open-im-server/v3/pkg/common/config"
"github.com/spf13/cobra"

config2 "github.com/openimsdk/open-im-server/v3/pkg/common/config"
)

type ApiCmd struct {
Expand Down
4 changes: 3 additions & 1 deletion pkg/common/cmd/rpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@ package cmd

import (
"errors"

"github.com/OpenIMSDK/protocol/constant"
config2 "github.com/openimsdk/open-im-server/v3/pkg/common/config"
"github.com/spf13/cobra"
"google.golang.org/grpc"

config2 "github.com/openimsdk/open-im-server/v3/pkg/common/config"

"github.com/OpenIMSDK/tools/discoveryregistry"

"github.com/openimsdk/open-im-server/v3/pkg/common/startrpc"
Expand Down
3 changes: 2 additions & 1 deletion pkg/common/config/parse.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ import (
"path/filepath"

"github.com/OpenIMSDK/protocol/constant"
"github.com/openimsdk/open-im-server/v3/pkg/msgprocessor"
"gopkg.in/yaml.v3"

"github.com/openimsdk/open-im-server/v3/pkg/msgprocessor"
)

//go:embed version
Expand Down
3 changes: 2 additions & 1 deletion pkg/common/db/relation/mysql_init.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ import (
"github.com/OpenIMSDK/tools/log"
"github.com/OpenIMSDK/tools/mw/specialerror"
mysqldriver "github.com/go-sql-driver/mysql"
"github.com/openimsdk/open-im-server/v3/pkg/common/config"
"gorm.io/driver/mysql"
"gorm.io/gorm"
"gorm.io/gorm/logger"

"github.com/openimsdk/open-im-server/v3/pkg/common/config"
)

const (
Expand Down
6 changes: 4 additions & 2 deletions pkg/common/discovery_register/k8s_discovery_register.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ import (
"context"
"errors"
"fmt"
"time"

"github.com/OpenIMSDK/tools/discoveryregistry"
openkeeper "github.com/OpenIMSDK/tools/discoveryregistry/zookeeper"
"github.com/OpenIMSDK/tools/log"
"github.com/openimsdk/open-im-server/v3/pkg/common/config"
"google.golang.org/grpc"
"time"

"github.com/openimsdk/open-im-server/v3/pkg/common/config"
)

func NewDiscoveryRegister(envType string) (discoveryregistry.SvcDiscoveryRegistry, error) {
Expand Down
6 changes: 3 additions & 3 deletions pkg/common/version/base.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ var (
// companion .gitattributes file containing 'export-subst' in this same
// directory. See also https://git-scm.com/docs/gitattributes
gitVersion string = "latest"
gitCommit string = "" // sha1 from git, output of $(git rev-parse HEAD)
gitTreeState string = "" // state of git tree, either "clean" or "dirty"
gitCommit string = "" // sha1 from git, output of $(git rev-parse HEAD)
gitTreeState string = "" // state of git tree, either "clean" or "dirty"

buildDate string = "1970-01-01T00:00:00Z" // build date in ISO8601 format, output of $(date -u +'%Y-%m-%dT%H:%M:%SZ')
)
)
18 changes: 9 additions & 9 deletions pkg/common/version/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ package version
// TODO: Add []string of api versions supported? It's still unclear
// how we'll want to distribute that information.
type Info struct {
Major string `json:"major,omitempty"`
Minor string `json:"minor,omitempty"`
GitVersion string `json:"gitVersion"`
Major string `json:"major,omitempty"`
Minor string `json:"minor,omitempty"`
GitVersion string `json:"gitVersion"`
GitTreeState string `json:"gitTreeState,omitempty"`
GitCommit string `json:"gitCommit,omitempty"`
BuildDate string `json:"buildDate"`
GoVersion string `json:"goVersion"`
Compiler string `json:"compiler"`
Platform string `json:"platform"`
GitCommit string `json:"gitCommit,omitempty"`
BuildDate string `json:"buildDate"`
GoVersion string `json:"goVersion"`
Compiler string `json:"compiler"`
Platform string `json:"platform"`
}

type Output struct {
Expand All @@ -21,7 +21,7 @@ type Output struct {
}

type OpenIMClientVersion struct {
ClientVersion string `json:"clientVersion,omitempty" yaml:"clientVersion,omitempty"` //sdk core version
ClientVersion string `json:"clientVersion,omitempty" yaml:"clientVersion,omitempty"` //sdk core version
}

// String returns info as a human-friendly version string.
Expand Down
16 changes: 8 additions & 8 deletions pkg/common/version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ func Get() Info {
// These variables typically come from -ldflags settings and in
// their absence fallback to the settings in ./base.go
return Info{
Major: gitMajor,
Minor: gitMinor,
GitVersion: gitVersion,
Major: gitMajor,
Minor: gitMinor,
GitVersion: gitVersion,
GitTreeState: gitTreeState,
GitCommit: gitCommit,
BuildDate: buildDate,
GoVersion: runtime.Version(),
Compiler: runtime.Compiler,
Platform: fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
GitCommit: gitCommit,
BuildDate: buildDate,
GoVersion: runtime.Version(),
Compiler: runtime.Compiler,
Platform: fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
}
}

Expand Down