Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka work error ,alertmanager work error #1455

Merged
merged 106 commits into from
Nov 21, 2023
Merged

Conversation

xuexihuang
Copy link
Contributor

@xuexihuang xuexihuang commented Nov 21, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1454

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

lin.huang and others added 30 commits September 24, 2023 06:17
lin.huang added 5 commits November 15, 2023 16:31
# Conflicts:
#	config/alertmanager.yml
#	config/email.tmpl
#	deployments/templates/prometheus.yml
#	docker-compose.yml
#	scripts/install/environment.sh
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2023
@kubbot
Copy link
Contributor

kubbot commented Nov 21, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md.
If you wish to sign the CRA, Please copy and comment on the following sentence:


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
✅ (xuexihuang)[https://github.com/xuexihuang]
✅ (cubxxw)[https://github.com/cubxxw]
❌ @lin.huang
lin.huang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Contributor

sweep-ai bot commented Nov 21, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@cubxxw cubxxw added this pull request to the merge queue Nov 21, 2023
Merged via the queue into openimsdk:main with commit 7a13284 Nov 21, 2023
17 of 18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Nov 21, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: kafka start error and alertmanager env config error
4 participants