Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix openim scripts and ci add openim check #1632

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 29, 2023


🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

The issue addressed by this PR is the lack of clarity in the current make check results, causing confusion and uncertainty about the underlying reasons. Additionally, the current CI system is not sufficiently robust.

🅰 Which issue(s) this PR fixes:

Fixes #1638

📝 Special notes for your reviewer:

🎯 Describe how to verify it

CICD
local test

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2023
Copy link
Contributor

sweep-ai bot commented Dec 29, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
skiffer-git
skiffer-git previously approved these changes Dec 29, 2023
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
@pull-request-size pull-request-size bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfde7bb) 5.13% compared to head (a014ce2) 5.13%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1632   +/-   ##
=====================================
  Coverage   5.13%   5.13%           
=====================================
  Files         42      42           
  Lines       3779    3779           
=====================================
  Hits         194     194           
  Misses      3574    3574           
  Partials      11      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGadvancer FGadvancer added this pull request to the merge queue Dec 29, 2023
Merged via the queue into openimsdk:main with commit 1e52376 Dec 29, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Dec 29, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Script to Check OpenIM Service Ports and Status
3 participants