-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix openim scripts and ci add openim check #1632
Merged
FGadvancer
merged 3 commits into
openimsdk:main
from
cubxxw:feat/fix-openim-ci-and-scripts
Dec 29, 2023
Merged
fix: fix openim scripts and ci add openim check #1632
FGadvancer
merged 3 commits into
openimsdk:main
from
cubxxw:feat/fix-openim-ci-and-scripts
Dec 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Apply Sweep Rules to your PR?
|
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
skiffer-git
previously approved these changes
Dec 29, 2023
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
=====================================
Coverage 5.13% 5.13%
=====================================
Files 42 42
Lines 3779 3779
=====================================
Hits 194 194
Misses 3574 3574
Partials 11 11 ☔ View full report in Codecov by Sentry. |
skiffer-git
approved these changes
Dec 29, 2023
FGadvancer
approved these changes
Dec 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
/kind documentation
/kind feature
👀 What this PR does / why we need it:
The issue addressed by this PR is the lack of clarity in the current make check results, causing confusion and uncertainty about the underlying reasons. Additionally, the current CI system is not sufficiently robust.
🅰 Which issue(s) this PR fixes:
Fixes #1638
📝 Special notes for your reviewer:
🎯 Describe how to verify it
CICD
local test
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: