Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when uploading logs, other ctrip writes caused upload failure #364

Merged
merged 8 commits into from
Oct 13, 2023
Merged

fix: when uploading logs, other ctrip writes caused upload failure #364

merged 8 commits into from
Oct 13, 2023

Conversation

withchao
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #363

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@withchao withchao requested a review from a team as a code owner October 13, 2023 07:15
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2023
@sweep-ai
Copy link

sweep-ai bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.

@withchao withchao temporarily deployed to openim October 13, 2023 07:15 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 07:15 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 07:15 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 13, 2023 07:15 — with GitHub Actions Inactive
@withchao withchao added this pull request to the merge queue Oct 13, 2023
Merged via the queue into openimsdk:main with commit 50c3f1f Oct 13, 2023
6 checks passed
@sweep-ai
Copy link

sweep-ai bot commented Oct 13, 2023

Created PR: #366 to fix All new business logic should have corresponding unit tests in the tests/ directory..
This PR was made against the main branch, not your main branch, so it's safe to merge if it looks good!

@sweep-ai
Copy link

sweep-ai bot commented Oct 13, 2023

Created PR: #367 to fix All new business logic should have corresponding unit tests in the tests/ directory..
This PR was made against the main branch, not your main branch, so it's safe to merge if it looks good!

@sweep-ai
Copy link

sweep-ai bot commented Oct 13, 2023

Created PR: #368 to fix All new business logic should have corresponding unit tests in the tests/ directory..
This PR was made against the main branch, not your main branch, so it's safe to merge if it looks good!

@sweep-ai
Copy link

sweep-ai bot commented Oct 13, 2023

Created PR: #369 to fix Any clearly inefficient or repeated code should be optimized or refactored..
This PR was made against the main branch, not your main branch, so it's safe to merge if it looks good!

@sweep-ai
Copy link

sweep-ai bot commented Oct 13, 2023

Created PR: #370 to fix Any clearly inefficient or repeated code should be optimized or refactored..
This PR was made against the main branch, not your main branch, so it's safe to merge if it looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: when uploading logs, other ctrip writes caused upload failure
3 participants