Refactor createapp #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaesang
reviewed
Dec 15, 2021
| { "path": "prometheus-operator", "namespace": "lma" }, | ||
| { "path": "eck-operator", "namespace": "elastic-system" }, | ||
| { "path": "fluentbit-operator", "namespace": "lma" } | ||
| { "app_group": "lma", "path": "prometheus-operator", "namespace": "lma", }, |
There was a problem hiding this comment.
수정했습니다. (테스트는 usercluster 생성 시나리오로 해봤었네요)
|
이 부분은 1번에 동의합니다.
|
ktkfree
approved these changes
Dec 16, 2021
Jaesang
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/openinfradev/tks-issues/issues/55 관련 내용을 반영한 PR 입니다.
어디서든 공통의 create-application workflow를 사용하게 하였고, 다양한 케이스에 대처하기 위해 몇가지 parameter를 추가하였습니다.
자세한 내용은 위의 이슈 내용 참고하시면 됩니다.
한가지 의견을 구하고 싶은 점은, app_prefix 인자를 추가하였는데, 둘 중 어느 쪽이 나은지 의견 부탁드립니다. (현재는 1번 안으로 되어있음)